Skip to content

Conversation

@Nesopie
Copy link
Collaborator

@Nesopie Nesopie commented Sep 22, 2025

Summary by CodeRabbit

  • New Features
    • Added public support for generating universal links to enable smoother mobile/deeplink flows.
  • Documentation
    • Introduced a “Mobile usage” section with examples for creating and using universal links.
  • Refactor
    • Consolidated internal utilities; no impact to existing integrations.
  • Chores
    • Bumped SDK package versions for QR code Angular and core QR code packages.

@Nesopie Nesopie merged commit c18cf43 into dev Sep 22, 2025
12 of 13 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removes sdk/qrcode-angular/src/common.ts (types, constants, builders, utilities), adds getUniversalLink to public exports in Angular and core QR code packages, updates README with mobile deeplink guidance, and bumps package versions for sdk/qrcode-angular and sdk/qrcode.

Changes

Cohort / File(s) Summary
Documentation
sdk/qrcode-angular/README.md
Adds “Mobile usage” section with deeplink flow guidance and code snippets for getUniversalLink.
Version bumps
sdk/qrcode-angular/package.json, sdk/qrcode/package.json
Increment versions: 1.0.11.0.2 (Angular), 1.0.141.0.15 (QR code).
Angular internal refactor
sdk/qrcode-angular/src/common.ts
Deletes module defining types, constants, SelfAppBuilder, utilities (formatEndpoint, validateUserId, getUniversalLink).
Public exports (Angular)
sdk/qrcode-angular/src/public-api.ts
Adds re-export of getUniversalLink from ./lib/common.
Public exports (QR code SDK)
sdk/qrcode/index.ts
Expands export from @selfxyz/common to include getUniversalLink alongside SelfAppBuilder.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • chore: export selfappbuilder #1092 — Also modifies sdk/qrcode/index.ts exports, overlapping surface with this PR.
  • fix: sdk #1085 — Touches getUniversalLink and related export/constants paths, indicating related API surface.
  • App/deeplink callback #789 — Interacts with deeplink functionality (deeplinkCallback/getUniversalLink), aligning with this PR’s export/docs changes.

Suggested labels

codex

Suggested reviewers

  • shazarre

Poem

QR codes whisper, links take flight,
A builder fades into the night.
Exports bloom where docs now sing,
Mobile taps invoke the string.
Versions tiptoe, small and sleek—
One universal link to seek. 🎯📱

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sdk-qrcode

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd82b3b and e412fee.

📒 Files selected for processing (6)
  • sdk/qrcode-angular/README.md (1 hunks)
  • sdk/qrcode-angular/package.json (1 hunks)
  • sdk/qrcode-angular/src/common.ts (0 hunks)
  • sdk/qrcode-angular/src/public-api.ts (1 hunks)
  • sdk/qrcode/index.ts (1 hunks)
  • sdk/qrcode/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nesopie Nesopie deleted the fix/sdk-qrcode branch September 22, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants